Repository navigation
Bound the inspector page list so a proof whose browser never opens fails in time - #173
LucaCappelletti94 wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
==========================================
+ Coverage 85.07% 87.82% +2.75%
==========================================
Files 188 188
Lines 50326 50351 +25
Branches 50326 50351 +25
==========================================
+ Hits 42813 44223 +1410
+ Misses 5414 4044 -1370
+ Partials 2099 2084 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
1 participant
The Android proof waits up to 90 seconds for the login tab, checking its deadline between rounds, but each round first lists the browser's tabs over the
adb forwardwith no timeout. When the demo never opens a tab, the forward accepts the connection and nothing answers, so the first round never returns and the proof hangs until the job limit kills it, leaving no evidence.list_pagesnow bounds the whole request byREPLY_BOUND, so the wait reaches its deadline and fails with "no browser tab opened". The iOS proof's two lookups use the same function and get the same bound.